docs(process): un-stub implemented id-keyed write-stdin/close-stdin#14
Merged
Conversation
The persistent-tier registry landed in astrid-runtime/astrid#867: the id-keyed write-stdin/close-stdin are implemented (pipe retained host-side, survives pooled-instance reset, 1 MiB cap, backpressure, ownership-checked, audited). Drops the stale (NOT YET IMPLEMENTED) tags on those two funcs and corrects the two PERSISTENT TIER banners that claimed the whole tier was stubbed 'until the registry lands'. The ProcessHandle (ephemeral) write-stdin/close-stdin, attach, and watch/unwatch remain genuinely deferred and keep their notes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation comments in host/[email protected] to reflect that the persistent registry has landed and its shapes are frozen. It also details the behavior and constraints of the write-stdin and close-stdin functions. The review feedback points out minor inconsistencies in terminology (using '1 MiB' instead of '1 MB') and spelling ('re-attached' instead of 'reattached') compared to the rest of the file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+509
to
+511
| /// Caps at 1 MiB/call (`too-large` above that); returns bytes written. The | ||
| /// retained pipe lives in the host registry, so a later instance that | ||
| /// re-attached keeps writing to the same child across pooled-instance |
There was a problem hiding this comment.
There are a couple of minor inconsistencies introduced in these new comments:
- Terminology (1 MiB vs 1 MB): The new comment uses
1 MiB/call, whereas other parts of the file (such as thetoo-largeerror on line 60 and the ephemeralwrite-stdinon line 382) use1 MB. It would be best to standardize on eitherMiBorMBthroughout the file depending on the exact byte limit enforced by the host. - Spelling (re-attached vs reattached): The term
reattachis used without a hyphen everywhere else in this file (e.g., lines 20, 203, 334, 466). Usingreattachedhere maintains consistency.
/// Caps at 1 MiB/call (too-large error above that); returns bytes written. The
/// retained pipe lives in the host registry, so a later instance that
/// reattached keeps writing to the same child across pooled-instance
4 tasks
The un-stub text claimed write-stdin is "all-or-nothing per call, so framed stdin is never torn". The host writes via write_all over a pipe, which can deliver a prefix before an I/O error and then marks the stream closed, so a failed write is NOT atomic and CAN tear a frame. Pipe writes are atomic only up to PIPE_BUF for a single write(), never for a 1 MiB write_all, so the contract cannot promise this. State the real semantics: a successful return wrote every byte; an error may have delivered a prefix and closes the stream.
joshuajbouw
added a commit
to astrid-runtime/astrid
that referenced
this pull request
Jun 8, 2026
…e-stdin WIT (#871) ## Linked Issue Closes #870 ## Summary The id-keyed persistent `write-stdin` / `close-stdin` were implemented in #867 (the registry retains the child's stdin pipe host-side, survives pooled-instance reset, 1 MiB-capped, backpressured, ownership-checked, audited) but had **no test**, and the WIT still tagged them `(NOT YET IMPLEMENTED)`. This adds the acceptance test and un-stubs the now-accurate WIT docs. Doc-only on the contract — no signature change. ## Changes - **Test** (`registry_tests.rs`): write-stdin delivers bytes to a persistent child; a second by-id write (needing only registry + id — exactly what a post-reset instance holds) still reaches the same child; `close-stdin` → clean EOF exit; over-cap → `too-large`; wrong-owner → `no-such-process`; post-close → `closed`. - **WIT** (submodule bump → astrid-runtime/wit#14): drops the stale `(NOT YET IMPLEMENTED)` tags on the id-keyed forms and corrects the two `PERSISTENT TIER` "stubbed until the registry lands" banners. Restages `wit-staging`. Signatures unchanged. - The ephemeral `ProcessHandle` form, `attach`, and `watch` / `unwatch` stay genuinely deferred and tagged. - CHANGELOG updated under `[Unreleased]`. ## Test Plan ### Automated - [x] `cargo test --workspace` passes - [x] No new clippy warnings Specifically: `cargo test -p astrid-capsule registry_tests` (the new acceptance test + existing registry tests pass); build green (WIT parses via bindgen). ## Checklist - [x] Linked to an issue - [x] CHANGELOG.md updated under `[Unreleased]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persistent-tier registry landed in astrid-runtime/astrid#867 — the id-keyed write-stdin/close-stdin are implemented (pipe retained host-side, survives pooled-instance reset, 1 MiB cap, backpressure, ownership-checked, audited). Drops the stale (NOT YET IMPLEMENTED) tags on those two funcs and corrects the two PERSISTENT TIER banners that claimed the whole tier was stubbed until the registry lands. Doc-only: signatures unchanged, no wire/binding impact. The ProcessHandle (ephemeral) write-stdin/close-stdin, attach, and watch/unwatch remain genuinely deferred and keep their notes.